Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storage token to be keyed by endpoint #134

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Update storage token to be keyed by endpoint #134

merged 1 commit into from
Dec 1, 2022

Conversation

jasong689
Copy link
Contributor

@jasong689 jasong689 commented Nov 30, 2022 •
edited
Loading

We noticed that session tokens are stored at the static token key and this ends up being re-used across different Gadget apps if you're building multiple embedded apps

closes GGT-2915

PR Checklist

  • Important or complicated code is tested
  • Any user facing changes are documented in the Gadget-side changelog
  • Any immediate changes are slated for release in Gadget via a generated package dependency bump
  • Versions within this monorepo are matching and there's a valid upgrade path

@jasong689 jasong689 force-pushed the token-by-endpoint branch 2 times, most recently from 658d64d to 6ca2d5a Compare November 30, 2022 19:02
@airhorns airhorns merged commit 52ea7f4 into main Dec 1, 2022
@airhorns airhorns deleted the token-by-endpoint branch December 1, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airhorns airhorns airhorns approved these changes

@kira-bruneau kira-bruneau kira-bruneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasong689 @airhorns @kira-bruneau