Switch to the multipart fetch exchange for urql to support file uploads #14
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegedge
approved these changes
Nov 22, 2021
| @@ -257,7 +258,7 @@ export class GadgetConnection { | |||
| fetch: this.fetch, | |||
| exchanges: [ | |||
| dedupExchange, | |||
| fetchExchange, | |||
| multipartFetchExchange, | |||
There was a problem hiding this comment.
Any performance issues to using this over fetchExchange? If yes, perhaps down the road we could provide a set of default exchanges from the generated API clients, based on whether or not there are file fields.
There was a problem hiding this comment.
The multipart fetch exchange does exactly the same thing as the fetchExchange when there's no files involved, it only does multipart stuff if there are files, so I don't think so! Woop woop!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches us over to using the built in bits of urql that support file uploads over graphql. We're gonna use https://github.com/jaydenseric/graphql-upload on the backend which
@urql/exchange-multipart-fetchworks with well! This exchange is a drop in replacement for the normal fetch exchange if you're not uploading files also, so we can roll it out ahead of time.All the integration testing of this thing is gonna happen Gadget side.
See https://formidable.com/open-source/urql/docs/api/multipart-fetch-exchange/ for more info on it.