Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default provider's loading value to true #166

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

alanko0511
Copy link
Contributor

Since OAuth and any other requests that set this loading value are executed almost instantly, setting the default value to false will make components that rely on this value flashes in the first render.

PR Checklist

  • Important or complicated code is tested
  • Any user facing changes are documented in the Gadget-side changelog
  • Any immediate changes are slated for release in Gadget via a generated package dependency bump
  • Versions within this monorepo are matching and there's a valid upgrade path

@alanko0511 alanko0511 marked this pull request as ready for review March 30, 2023 14:27
@danroberts danroberts self-requested a review April 19, 2023 17:47
Copy link
Contributor

@jasong689 jasong689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to update the default value in context as well

@alanko0511 alanko0511 force-pushed the alan/change-default-loading-value branch from f231c5f to aac7eb5 Compare April 19, 2023 18:03
@alanko0511 alanko0511 merged commit eb980c8 into main Apr 19, 2023
@alanko0511 alanko0511 deleted the alan/change-default-loading-value branch April 19, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants