Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bulkCreate method in api-client-core 0.13.7 #185

Merged
merged 9 commits into from
May 4, 2023
Merged

bulkCreate method in api-client-core 0.13.7 #185

merged 9 commits into from
May 4, 2023

Conversation

jcao49
Copy link
Contributor

@jcao49 jcao49 commented May 2, 2023 •
edited
Loading

We added a new graphql internal mutation method bulkCreate to create many records. We need to update the @gadget/api-client-core package to include the new method in the internalModelManager so that the type can be accessed in a user's sandbox.

Closes: GGT-3936
Related: GGT-3399 | PR

PR Checklist

  • Important or complicated code is tested
  • Any user facing changes are documented in the Gadget-side changelog
  • Any immediate changes are slated for release in Gadget via a generated package dependency bump
  • Versions within this monorepo are matching and there's a valid upgrade path

@jcao49 jcao49 force-pushed the ggt-3936/bulk_create branch 2 times, most recently from f238288 to 848af72 Compare May 2, 2023 16:54
@jcao49 jcao49 marked this pull request as ready for review May 2, 2023 20:08
@jcao49 jcao49 changed the title Ggt 3936/bulk create bulkCreate method in api-client-core May 2, 2023
@jcao49 jcao49 mentioned this pull request May 2, 2023
Merged
4 tasks
@jcao49 jcao49 requested review from airhorns and kristianpd May 2, 2023 20:32
airhorns
airhorns reviewed May 2, 2023
View reviewed changes
packages/api-client-core/package.json Outdated Show resolved Hide resolved
packages/api-client-core/package.json Outdated Show resolved Hide resolved
@jcao49 jcao49 requested a review from airhorns May 3, 2023 16:31
airhorns
airhorns approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@airhorns airhorns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular! LGTM!

@jcao49 jcao49 changed the title bulkCreate method in api-client-core bulkCreate method in api-client-core 0.13.7 May 3, 2023
@jcao49 jcao49 merged commit 87fab78 into main May 4, 2023
@jcao49 jcao49 deleted the ggt-3936/bulk_create branch May 4, 2023 13:54
@jcao49 jcao49 mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airhorns airhorns airhorns approved these changes

@kristianpd kristianpd Awaiting requested review from kristianpd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcao49 @airhorns @MikePresman