Ensure a properly scaled bounding box #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for the amazing work, @gadomski ! Currently, the bounding box of the LAS file may be invalid in some pathologic cases. Consider the points specified in the csv file attached. If the included coordinates are serialized with the default
Transform
and the resulting file is checked with lasinfo, the software will warn about multiple issues:While the first warnings regarding the scaling of the bounding box may be neglectable the point outside of the bounding box is it clearly not. For example, it will seriously hinder the visualisation with potree.
This patch scales the bounding box accordingly to the transform, too. As a direct implication there are no longer any problems with the bounding box and floating-point issues.