-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pandas optional #43
Conversation
5019562
to
5f7f000
Compare
dafb6a3
to
3279e1b
Compare
Dear @gadomski , please re-review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3279e1b
to
5f2ab9b
Compare
Dear @gadomski , I really can't seem to understand your policy here. You said before that
though the commit you did both
Also, the marker should just be helpful - which it is per se. I'm really confused now, please clear my worries 😵💫 |
Yeah, I apologize @gutzbenj, thanks for your patience. I only come back to this project every once in a while and sometimes I forget previous decisions I've made 🙃 . To avoid further confusion, I've rolled up both of these PRs with my current way of thinking into #47. Thanks for your contribution! |
Dear @gadomski ,
this PR makes pandas optional (still installable via
isd[io]
)