-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translation of WTForms strings - SUPERSEDED (by #13) #10
Conversation
I'm quite confused with all these changes.. cause like I said.. I would rather wait with the version 2.0 of the WTForms before breaking backward compatibilities... Also I remember playing around with the |
Of course, feel free to postpone to a later date.
I know that's the plan... However, I needed to get this translation stuff working ASAP and thus pushed forward to make it happen with current stable releases of the libraries involved. Scratching my own itch...
Understand, and no problem with that. In fact, gae-init/gae-init#47 "Updated Flask-WTF to 0.9.3" (the PR for the gae-init parent project) will need to get some updates based on #8 here. I will push these updates there; based on what I learned here... I will do that just for completeness, knowing you will probably postpone merging (again: no problem). The #9 "Updated Flask-Babel to 0.9" referenced here, is a gae-init-babel specific PR and IMO could be applied. Though you may want to postpone based on your analysis of:
My current understanding (as reflected in the PRs) is based on http://flask.pocoo.org/docs/extensiondev/#anatomy-of-an-extension which IMO shows that the flask.ext. notation can be followed to find the extensions; and in recent incarnations of Flask the Extensions seem to be moving towards a more maintainable structure.
Sure, and if/when the PRs become obsolete due to WTForms 2.0 release, so be it; no hard feelings. |
Maybe the last commit above can work without updating Flask-WTF and Flask-Babel. I'll try it now and report back here and/or in another PR, just to blow your mind :-) |
Closing this PR, as the new #12 "Fix translation of WTForms strings (simplified)" provides a much easier to understand solution. |
Bumps [eslint](https://github.com/eslint/eslint) from 5.6.1 to 5.7.0. <details> <summary>Release notes</summary> *Sourced from [eslint's releases](https://github.com/eslint/eslint/releases).* > ## v5.7.0 > * 6cb63fd Update: Add iife to padding-line-between-statements (fixes [#10853](https://github-redirect.dependabot.com/eslint/eslint/issues/10853)) ([#10916](https://github-redirect.dependabot.com/eslint/eslint/issues/10916)) (Kevin Partington) > * 5fd1bda Update: no-tabs allowIndentationTabs option (fixes [#10256](https://github-redirect.dependabot.com/eslint/eslint/issues/10256)) ([#10925](https://github-redirect.dependabot.com/eslint/eslint/issues/10925)) (Kevin Partington) > * d12be69 Fix: no-extra-bind No autofix if arg may have side effect (fixes [#10846](https://github-redirect.dependabot.com/eslint/eslint/issues/10846)) ([#10918](https://github-redirect.dependabot.com/eslint/eslint/issues/10918)) (Kevin Partington) > * 847372f Fix: no-unused-vars false pos. with markVariableAsUsed (fixes [#10952](https://github-redirect.dependabot.com/eslint/eslint/issues/10952)) ([#10954](https://github-redirect.dependabot.com/eslint/eslint/issues/10954)) (Roy Sutton) > * 4132de7 Chore: Simplify space-infix-ops ([#10935](https://github-redirect.dependabot.com/eslint/eslint/issues/10935)) (Bence Dányi) > * 543edfa Fix: Fix error with one-var (fixes [#10937](https://github-redirect.dependabot.com/eslint/eslint/issues/10937)) ([#10938](https://github-redirect.dependabot.com/eslint/eslint/issues/10938)) (Justin Krup) > * 95c4cb1 Docs: Fix typo for no-unsafe-finally ([#10945](https://github-redirect.dependabot.com/eslint/eslint/issues/10945)) (Sergio Santoro) > * 5fe0e1a Fix: no-invalid-regexp disallows \ at end of pattern (fixes [#10861](https://github-redirect.dependabot.com/eslint/eslint/issues/10861)) ([#10920](https://github-redirect.dependabot.com/eslint/eslint/issues/10920)) (Toru Nagashima) > * f85547a Docs: Add 'When Not To Use' section to space-infix-ops ([#10931](https://github-redirect.dependabot.com/eslint/eslint/issues/10931)) (Bence Dányi) > * 3dccac4 Docs: Update working-with-parsers link ([#10929](https://github-redirect.dependabot.com/eslint/eslint/issues/10929)) (Azeem Bande-Ali) > * 557a8bb Docs: Remove old note about caching, add a new one (fixes [#10739](https://github-redirect.dependabot.com/eslint/eslint/issues/10739)) ([#10913](https://github-redirect.dependabot.com/eslint/eslint/issues/10913)) (Zac) > * fe8111a Chore: Add more test cases to space-infix-ops ([#10936](https://github-redirect.dependabot.com/eslint/eslint/issues/10936)) (Bence Dányi) > * 066f7e0 Update: camelcase rule ignoreList added ([#10783](https://github-redirect.dependabot.com/eslint/eslint/issues/10783)) (Julien Martin) > * 70bde69 Upgrade: table to version 5 ([#10903](https://github-redirect.dependabot.com/eslint/eslint/issues/10903)) (Rouven Weßling) > * 2e52bca Chore: Update issue templates ([#10900](https://github-redirect.dependabot.com/eslint/eslint/issues/10900)) (Nicholas C. Zakas) </details> <details> <summary>Changelog</summary> *Sourced from [eslint's changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md).* > v5.7.0 - October 12, 2018 > > * 6cb63fd Update: Add iife to padding-line-between-statements (fixes [#10853](https://github-redirect.dependabot.com/eslint/eslint/issues/10853)) ([#10916](https://github-redirect.dependabot.com/eslint/eslint/issues/10916)) (Kevin Partington) > * 5fd1bda Update: no-tabs allowIndentationTabs option (fixes [#10256](https://github-redirect.dependabot.com/eslint/eslint/issues/10256)) ([#10925](https://github-redirect.dependabot.com/eslint/eslint/issues/10925)) (Kevin Partington) > * d12be69 Fix: no-extra-bind No autofix if arg may have side effect (fixes [#10846](https://github-redirect.dependabot.com/eslint/eslint/issues/10846)) ([#10918](https://github-redirect.dependabot.com/eslint/eslint/issues/10918)) (Kevin Partington) > * 847372f Fix: no-unused-vars false pos. with markVariableAsUsed (fixes [#10952](https://github-redirect.dependabot.com/eslint/eslint/issues/10952)) ([#10954](https://github-redirect.dependabot.com/eslint/eslint/issues/10954)) (Roy Sutton) > * 4132de7 Chore: Simplify space-infix-ops ([#10935](https://github-redirect.dependabot.com/eslint/eslint/issues/10935)) (Bence Dányi) > * 543edfa Fix: Fix error with one-var (fixes [#10937](https://github-redirect.dependabot.com/eslint/eslint/issues/10937)) ([#10938](https://github-redirect.dependabot.com/eslint/eslint/issues/10938)) (Justin Krup) > * 95c4cb1 Docs: Fix typo for no-unsafe-finally ([#10945](https://github-redirect.dependabot.com/eslint/eslint/issues/10945)) (Sergio Santoro) > * 5fe0e1a Fix: no-invalid-regexp disallows \ at end of pattern (fixes [#10861](https://github-redirect.dependabot.com/eslint/eslint/issues/10861)) ([#10920](https://github-redirect.dependabot.com/eslint/eslint/issues/10920)) (Toru Nagashima) > * f85547a Docs: Add 'When Not To Use' section to space-infix-ops ([#10931](https://github-redirect.dependabot.com/eslint/eslint/issues/10931)) (Bence Dányi) > * 3dccac4 Docs: Update working-with-parsers link ([#10929](https://github-redirect.dependabot.com/eslint/eslint/issues/10929)) (Azeem Bande-Ali) > * 557a8bb Docs: Remove old note about caching, add a new one (fixes [#10739](https://github-redirect.dependabot.com/eslint/eslint/issues/10739)) ([#10913](https://github-redirect.dependabot.com/eslint/eslint/issues/10913)) (Zac) > * fe8111a Chore: Add more test cases to space-infix-ops ([#10936](https://github-redirect.dependabot.com/eslint/eslint/issues/10936)) (Bence Dányi) > * 066f7e0 Update: camelcase rule ignoreList added ([#10783](https://github-redirect.dependabot.com/eslint/eslint/issues/10783)) (Julien Martin) > * 70bde69 Upgrade: table to version 5 ([#10903](https://github-redirect.dependabot.com/eslint/eslint/issues/10903)) (Rouven Weßling) > * 2e52bca Chore: Update issue templates ([#10900](https://github-redirect.dependabot.com/eslint/eslint/issues/10900)) (Nicholas C. Zakas) </details> <details> <summary>Commits</summary> - [`77bb207`](eslint/eslint@77bb207) 5.7.0 - [`aa599c4`](eslint/eslint@aa599c4) Build: changelog update for 5.7.0 - [`536611a`](eslint/eslint@536611a) Revert "Build: Use karma-chrome-launcher to run tests ([#10898](https://github-redirect.dependabot.com/eslint/eslint/issues/10898))" ([#10973](https://github-redirect.dependabot.com/eslint/eslint/issues/10973)) - [`6cb63fd`](eslint/eslint@6cb63fd) Update: Add iife to padding-line-between-statements (fixes [#10853](https://github-redirect.dependabot.com/eslint/eslint/issues/10853)) ([#10916](https://github-redirect.dependabot.com/eslint/eslint/issues/10916)) - [`5fd1bda`](eslint/eslint@5fd1bda) Update: no-tabs allowIndentationTabs option (fixes [#10256](https://github-redirect.dependabot.com/eslint/eslint/issues/10256)) ([#10925](https://github-redirect.dependabot.com/eslint/eslint/issues/10925)) - [`d12be69`](eslint/eslint@d12be69) Fix: no-extra-bind No autofix if arg may have side effect (fixes [#10846](https://github-redirect.dependabot.com/eslint/eslint/issues/10846)) ([#10](https://github-redirect.dependabot.com/eslint/eslint/issues/10)... - [`847372f`](eslint/eslint@847372f) Fix: no-unused-vars false pos. with markVariableAsUsed (fixes [#10952](https://github-redirect.dependabot.com/eslint/eslint/issues/10952)) ([#10954](https://github-redirect.dependabot.com/eslint/eslint/issues/10954)) - [`4132de7`](eslint/eslint@4132de7) Chore: Simplify space-infix-ops ([#10935](https://github-redirect.dependabot.com/eslint/eslint/issues/10935)) - [`543edfa`](eslint/eslint@543edfa) Fix: Fix error with one-var (fixes [#10937](https://github-redirect.dependabot.com/eslint/eslint/issues/10937)) ([#10938](https://github-redirect.dependabot.com/eslint/eslint/issues/10938)) - [`95c4cb1`](eslint/eslint@95c4cb1) Docs: Fix typo for no-unsafe-finally ([#10945](https://github-redirect.dependabot.com/eslint/eslint/issues/10945)) - Additional commits viewable in [compare view](eslint/eslint@v5.6.1...v5.7.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=5.6.1&new-version=5.7.0)](https://dependabot.com/compatibility-score.html?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=5.6.1&new-version=5.7.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
This resolves the #6 "Strings that are in WTForms are not translated" issue; it currently builds on top of #8 "Updated Flask-WTF to 0.9.3" and #9 "Updated Flask-Babel to 0.9" (which are already merged in this pull request).