Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct access to signin fails, due to new is_trusted_url logic #709

Closed
benoitpointet opened this issue Aug 28, 2017 · 0 comments
Closed

Comments

@benoitpointet
Copy link

In get_next_url the fallback return value is the referrer, through is_trusted_url.
Yet in the case of a direct access to signin, there's no referrer and thus the signin page returns an error.

return is_trusted_url(flask.request.referrer)

I changed that line in my project to the following (although I'm really not sure that's the right way):

  if flask.request.referrer:
    return is_trusted_url(flask.request.referrer)
  return ''
gmist added a commit to gmist/my-gae-init that referenced this issue Aug 28, 2017
@lipis lipis closed this as completed in dc3f0d5 Aug 28, 2017
lipis added a commit that referenced this issue Oct 9, 2017
* master: (40 commits)
  Pre-release version 5.9.5
  Update requirements (#721)
  Version 5.9.4
  New path for stubs.py (#719)
  chore(package): update yargs-parser to version 8.0.0 (#718)
  chore(package): update uglify-js to version 3.1.3 (#717)
  chore(package): update bower to version 1.8.2
  chore(package): update uglify-js to version 3.1.2
  chore(package): update uglify-js to version 3.1.1
  chore(package): update uglify-js to version 3.1.0 (#711)
  Fix and close #709 (#710)
  Fix linter warnings (#708)
  chore(package): update gulp-sourcemaps to version 2.6.1 (#706)
  chore(package): update uglify-js to version 3.0.28 (#707)
  Revert "Add "Alternative Token" handling for flask-login (see #699)" (#705)
  chore(package): update browser-sync to version 2.18.13 (#700)
  chore(package): update uglify-js to version 3.0.25 (#697)
  Add "Alternative Token" handling for flask-login (see #699) (#701)
  chore(package): update coffee-script to version 1.12.7 (#698)
  chore(package): update uglify-js to version 3.0.24 (#696)
  ...
rbubley pushed a commit to rbubley/gae-init that referenced this issue Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant