Fixed caps of Trusted Hosts #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipis
reviewed
Apr 17, 2017
| @@ -26,7 +26,7 @@ class Config(model.Base, model.ConfigAuth): | |||
| recaptcha_private_key = ndb.StringProperty(default='', verbose_name='Private Key') | |||
| recaptcha_public_key = ndb.StringProperty(default='', verbose_name='Public Key') | |||
| salt = ndb.StringProperty(default=util.uuid()) | |||
| trusted_hosts = ndb.StringProperty(repeated=True, verbose_name='Trusted hosts') | |||
| trusted_hosts = ndb.StringProperty(repeated=True, verbose_name='Trusted Hosts') | |||
There was a problem hiding this comment.
Even though lately I prefer the sentence case we'll have to keep it consistent :)
Here is an interesting post about it..
https://medium.com/@jsaito/making-a-case-for-letter-case-19d09f653c98
There was a problem hiding this comment.
Yeah, don't mind either way as long as there is consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed capitalisation of Trusted Hosts on configuration page; making it more in sync with how other elements are capitalised (like Brand Name. Feedback Email, and Let's Encrypt Challenge).