-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New hot
API
#1122
New hot
API
#1122
Conversation
…-loader into hooks-fix-6-12
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
- Coverage 84.89% 84.05% -0.84%
==========================================
Files 33 37 +4
Lines 1026 1154 +128
Branches 258 281 +23
==========================================
+ Hits 871 970 +99
- Misses 121 143 +22
- Partials 34 41 +7
Continue to review full report at Codecov.
|
Next step - on |
I think it is very nice to simplify API and to remove the magic "module" part! Good job! |
@neoziro - you know - I do have the same problem. Sometimes I am thinking to start everything, especially tests, from scratch. |
This PR is aimed to solve 2 issues:
errorReporter
using hot - there were several issues about it, like Example Error Boundary #1111module.hot.accept
and that's lead to full page reload next time - Hot reloading shouldn't stop after an error #1078The change
hot
into two piecesIf "first" part is called, but second is not - then some JS error took a place, and we should display an Error overlay.