-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"The same prototype" #859
Merged
Merged
"The same prototype" #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #859 +/- ##
==========================================
+ Coverage 86.97% 87.22% +0.24%
==========================================
Files 30 30
Lines 622 634 +12
Branches 147 149 +2
==========================================
+ Hits 541 553 +12
Misses 65 65
Partials 16 16
Continue to review full report at Codecov.
|
@theKashey conflict |
resolved, just "squash" merge to hide unnecessary commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other words - transfer original class methods into the Proxy prototype, fixes #858
The idea is to leverage a bit side effect caused by React-Hot-Loader's ProxyComponent, to be more concrete - have the same class members list on the top level prototype.
I could not say, that this is super common case, but RHL have to be just a bit more transparent.
https://github.com/uber/react-map-gl/blob/b50de38ab0dfed9e976e1d2e6b0c040629bd82b5/src/utils/autobind.js
Related to
visgl/react-map-gl#461