Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Condition render in Fragments. #942 #943

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

theKashey
Copy link
Collaborator

As long adding "holes" into the test make them red, and then I've managed to make them green - considered as fix.

See #942

@codecov-io
Copy link

Codecov Report

Merging #943 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #943   +/-   ##
=======================================
  Coverage   88.11%   88.11%           
=======================================
  Files          30       30           
  Lines         673      673           
  Branches      155      155           
=======================================
  Hits          593      593           
  Misses         65       65           
  Partials       15       15
Impacted Files Coverage Δ
src/reconciler/hotReplacementRender.js 88.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c406a8...a2f6e04. Read the comment docs.

@gregberge gregberge merged commit 2549a18 into master Apr 24, 2018
@gregberge gregberge deleted the fix-holes-in-fragments branch April 24, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants