Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task Create_Changelog_Branch #381

Merged
merged 2 commits into from May 29, 2022
Merged

Conversation

johlju
Copy link
Collaborator

@johlju johlju commented May 29, 2022

Pull Request

Pull Request (PR) description

Added

  • Added task Create_Release_Branch to push a branch containing the updated
    change log after release. Fixes #351

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label May 29, 2022
@johlju johlju requested a review from gaelcolas May 29, 2022 06:20
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #381 (c47c126) into main (6e032d1) will increase coverage by 1%.
The diff coverage is 73%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #381   +/-   ##
===================================
+ Coverage    28%    30%   +1%     
===================================
  Files        42     43    +1     
  Lines      2261   2334   +73     
===================================
+ Hits        649    703   +54     
- Misses     1612   1631   +19     
Impacted Files Coverage Δ
.build/tasks/Create_Release_Git_Tag.build.ps1 66% <66%> (ø)
.build/tasks/Create_Changelog_Branch.build.ps1 73% <73%> (ø)

Copy link
Owner

@gaelcolas gaelcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@johlju johlju merged commit 2bfc9c0 into gaelcolas:main May 29, 2022
@johlju johlju deleted the f/add-second-task branch May 29, 2022 08:12
@johlju johlju removed the needs review The pull request needs a code review. label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with Azure DevOps Repos: Decouple git tagging from Sampler.GitHubTasks
2 participants