Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add j_actuator calcuation to omas physics #170

Merged
merged 17 commits into from
Sep 28, 2021
Merged

add j_actuator calcuation to omas physics #170

merged 17 commits into from
Sep 28, 2021

Conversation

jmcclena
Copy link
Collaborator

No description provided.

omas/omas_physics.py Outdated Show resolved Hide resolved
omas/omas_physics.py Outdated Show resolved Hide resolved
@jmcclena jmcclena mentioned this pull request Sep 20, 2021
Copy link
Member

@orso82 orso82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more general core_profiles_currents_summary should take ax and not fig as argument. All the rest are minor comments.

omas/omas_physics.py Outdated Show resolved Hide resolved
omas/omas_physics.py Outdated Show resolved Hide resolved
omas/omas_plot.py Outdated Show resolved Hide resolved
omas/omas_plot.py Outdated Show resolved Hide resolved
omas/omas_plot.py Show resolved Hide resolved
@@ -1040,6 +1040,52 @@ def equilibrium_summary(ods, time_index=None, time=None, fig=None, ggd_points_tr

return {'ax': axs}

@add_to__ODS__
def core_profiles_currents_summary(ods, time_index=None, time=None, fig=None, **kw):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function plots all in one axis. So it would be more general to not take fig as an input argument, but rather take ax. This would allow this function to be used in someone's figure (maybe with different subplots). See for example the core_profiles_pressures( ) function.

TimSlendebroek and others added 8 commits September 22, 2021 11:30
Co-authored-by: Orso Meneghini <orso82@gmail.com>
Co-authored-by: Orso Meneghini <orso82@gmail.com>
Co-authored-by: Orso Meneghini <orso82@gmail.com>
Co-authored-by: Orso Meneghini <orso82@gmail.com>
Co-authored-by: Orso Meneghini <orso82@gmail.com>
@TimSlendebroek
Copy link
Contributor

can we merge this now @orso82 @jmcclena

@orso82 orso82 merged commit 1bc2b0c into master Sep 28, 2021
@orso82 orso82 deleted the jact branch September 28, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants