New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pint>=0.20) use pint.Quantity for isintance check instead of pint.quantity._Quantity #265

Merged

orso82 merged 1 commit into gafusion:master from hassec:hassec_pint

Aug 16, 2023

Contributor

hassec commented Aug 16, 2023 •

edited

Loading

Fixes #263

This should even be backwards compatible because in older pint versions
pint.Quantity is just pointing to pint.quantity._Quantity.

I tested make test_physics with pint==0.19 and pint==0.22 and the tests passed in both cases.


          fix(pint>=0.20) use pint.Quantity for isintance check instead of pint…

e8b01a7

….quantity._Quantity

hassec mentioned this pull request

Test failure with pint>=0.20 #263

Closed

orso82 merged commit 0cd6e21 into gafusion:master

1 check passed

Member

orso82 commented Aug 16, 2023

Fantastic! Thanks!

@hassec do you use the pint functionality in OMAS? #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet