Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stri_locate_first_boundaries etc. #120

Closed
hadley opened this issue Nov 27, 2014 · 2 comments
Closed

stri_locate_first_boundaries etc. #120

hadley opened this issue Nov 27, 2014 · 2 comments
Assignees
@gagolews
Labels
enhancement high priority
Milestone
stringi-0.4

Comments

@hadley
Copy link

hadley commented Nov 27, 2014

It seems like stri_locate_boundaries() is implicitly stri_locate_all_boundaries and it would be nice to have a matching stri_locate_first_boundaries().

(I don't have a burning need for this, but stringr uses the convention (from base R) that pattern = "" means to find character boundaries)
@gagolews
Copy link
Owner

Sure.

@gagolews gagolews added this to the stringi-0.4 milestone Nov 27, 2014
@gagolews
Copy link
Owner

  • stri_locate_first_boundaries, stri_locate_last_boundaries
  • stri_locate_first_words, stri_locate_last_words
  • stri_extract_first_words, stri_extract_last_words.
  • stri_search_boundaries.cpp should be split into a few separate C++ source files
  • stri_locate_boundaries -> stri_locate_all_boundaries
  • stri_locate_words -> stri_locate_all_words
  • stri_extract_words -> stri_extract_all_words

@gagolews gagolews changed the title Locate first boundary? stri_locate_first_boundaries etc. Nov 27, 2014
gagolews added a commit that referenced this issue Dec 3, 2014
@gagolews
#120, #113, #121: new classes: StriBrkIterOptions, StriUBreakIterator…
79823d0 
…, StriRuleBasedBreakIterator
gagolews added a commit that referenced this issue Dec 5, 2014
@gagolews
(ref #120) split stri_search_boundaries.cpp
b090b59
gagolews added a commit that referenced this issue Dec 5, 2014
@gagolews
#120: stri_extract_words has been renamed stri_extract_all_words …
5c0c542 
…and `stri_locate_boundaries` - `stri_locate_all_boundaries` as well as `stri_locate_words` - `stri_locate_all_words`.
@gagolews gagolews self-assigned this Dec 5, 2014
gagolews added a commit that referenced this issue Dec 5, 2014
@gagolews
#120: New functions are now available: , , ,
20721d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gagolews gagolews

Labels
enhancement high priority
Projects
None yet
Milestone
stringi-0.4
Development

No branches or pull requests
2 participants
@hadley @gagolews