New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stri_locate_first_boundaries etc. #120

Closed
hadley opened this Issue Nov 27, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@hadley

hadley commented Nov 27, 2014

It seems like stri_locate_boundaries() is implicitly stri_locate_all_boundaries and it would be nice to have a matching stri_locate_first_boundaries().

(I don't have a burning need for this, but stringr uses the convention (from base R) that pattern = "" means to find character boundaries)

@gagolews

This comment has been minimized.

Show comment
Hide comment
@gagolews

gagolews Nov 27, 2014

Owner

Sure.

Owner

gagolews commented Nov 27, 2014

Sure.

@gagolews

This comment has been minimized.

Show comment
Hide comment
@gagolews

gagolews Nov 27, 2014

Owner
  • stri_locate_first_boundaries, stri_locate_last_boundaries
  • stri_locate_first_words, stri_locate_last_words
  • stri_extract_first_words, stri_extract_last_words.
  • stri_search_boundaries.cpp should be split into a few separate C++ source files
  • stri_locate_boundaries -> stri_locate_all_boundaries
  • stri_locate_words -> stri_locate_all_words
  • stri_extract_words -> stri_extract_all_words
Owner

gagolews commented Nov 27, 2014

  • stri_locate_first_boundaries, stri_locate_last_boundaries
  • stri_locate_first_words, stri_locate_last_words
  • stri_extract_first_words, stri_extract_last_words.
  • stri_search_boundaries.cpp should be split into a few separate C++ source files
  • stri_locate_boundaries -> stri_locate_all_boundaries
  • stri_locate_words -> stri_locate_all_words
  • stri_extract_words -> stri_extract_all_words

@gagolews gagolews changed the title from Locate first boundary? to stri_locate_first_boundaries etc. Nov 27, 2014

gagolews added a commit that referenced this issue Dec 3, 2014

gagolews added a commit that referenced this issue Dec 5, 2014

#120: `stri_extract_words` has been renamed `stri_extract_all_words` …
…and `stri_locate_boundaries` - `stri_locate_all_boundaries` as well as `stri_locate_words` - `stri_locate_all_words`.

@gagolews gagolews self-assigned this Dec 5, 2014

@gagolews gagolews closed this in 917d2f7 Dec 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment