-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored scheduler out of the service singleton provider #237
Conversation
@michelvocks Bask in this beauty! :)) Arguably, the naming could be better, also, I'm thinking of creating some more folders in order to separate the provider and the services better. However, this works ( I can now see that some of the tests failed, although locally everything ran... grrr. EDIT: Oh right.. The worker tests...:D ). It makes the tests a heck of a lot more stable because you don't have to worry about the fact that something overwrites your mock. Eventually, if you like this way, I would like to refactor the rest of the singletons as well into services and providers. |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 60.64% 62.82% +2.18%
==========================================
Files 49 48 -1
Lines 4304 3844 -460
==========================================
- Hits 2610 2415 -195
+ Misses 1241 1028 -213
+ Partials 453 401 -52
Continue to review full report at Codecov.
|
After master merge this isn't scheduling properly... hm 🤔 |
This is now working, however I need to do some exhaustive testing around triggering, agent, docker runners and remote workers as well. |
Tested remote worker: ✅ |
No description provided.