Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using brim in landscape mode only #17

Open
BrendanBerkley opened this issue Oct 1, 2015 · 3 comments
Open

Using brim in landscape mode only #17

BrendanBerkley opened this issue Oct 1, 2015 · 3 comments

Comments

@BrendanBerkley
Copy link

Got a basic brim implementation going. Seems to mostly do what I want it to do, but I only need it to work in landscape mode.

Is this possible with the script today?

Thanks for your hard work on this!

@gajus
Copy link
Owner

gajus commented Oct 1, 2015

What is the expected behaviour in the landscape mode?

@BrendanBerkley
Copy link
Author

Exactly the same as your demo, but portrait mode would act as though brim
doesn't exist at all.

On Thu, Oct 1, 2015 at 5:57 PM, Gajus Kuizinas notifications@github.com
wrote:

What is the expected behaviour in the landscape mode?


Reply to this email directly or view it on GitHub
#17 (comment).

@gajus
Copy link
Owner

gajus commented Oct 2, 2015

"doesn't exist at all" is a rather broad definition. What if there was a viewport tag before loading Brim. Should Brim re-add it?

On Oct 2, 2015, at 13:22, Brendan Berkley notifications@github.com wrote:

Exactly the same as your demo, but portrait mode would act as though brim
doesn't exist at all.

On Thu, Oct 1, 2015 at 5:57 PM, Gajus Kuizinas notifications@github.com
wrote:

What is the expected behaviour in the landscape mode?


Reply to this email directly or view it on GitHub
#17 (comment).


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants