fix: skip type-import-style identifier in "declare module" (#394)

gajus · Apr 3, 2019 · 0f8a9b5 · 0f8a9b5
1 parent 6748dc5
commit 0f8a9b5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/rules/typeImportStyle.js b/src/rules/typeImportStyle.js
@@ -34,13 +34,26 @@ const create = (context) => {
     // Default to 'identifier'
     const ignoreTypeDefault = context.options[1] &&
       context.options[1].ignoreTypeDefault;
+    let isInsideDeclareModule = false;
 
     return {
+      DeclareModule () {
+        isInsideDeclareModule = true;
+      },
+      'DeclareModule:exit' () {
+        isInsideDeclareModule = false;
+      },
       ImportDeclaration (node) {
         if (node.importKind !== 'type') {
           return;
         }
 
+        // type specifiers are not allowed inside module declarations:
+        // https://github.com/facebook/flow/issues/7609
+        if (isInsideDeclareModule) {
+          return;
+        }
+
         if (
           ignoreTypeDefault &&
           node.specifiers[0] &&

diff --git a/tests/rules/assertions/typeImportStyle.js b/tests/rules/assertions/typeImportStyle.js
@@ -51,6 +51,10 @@ export default {
     {
       code: 'import type A from \'a\';',
       options: ['identifier', {ignoreTypeDefault: true}]
+    },
+    {
+      code: 'declare module "m" { import type A from \'a\'; }',
+      options: ['identifier']
     }
   ]
 };