fix: object-type-delimeter with new babel-eslint #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using babel-eslint 8.2.1, the object-type-delimeter rule does nothing,
apparently because the ObjectType{CallProperty,Indexer,Property} nodes
no longer contain trailing semicolons/commas, but their parent
ObjectTypeAnnotation nodes do.
I tried to keep compatibility with both cases, because it's not clear
what version this project is targeting. However, I don't know of a good
way to test the new behavior given the version of babel-eslint now
locked in devDependencies.
|
I did test the new code path in my own project by manually updating node_modules/eslint-plugin-flowtype/dist/rules/objectTypeDelimiter.js with these changes, and running eslint; the object-type-delimeter rule then started reporting errors as expected. Since tests pass here, it appears to still work with the older dependency too. |
|
🎉 This PR is included in version 2.49.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using babel-eslint 8.2.1, the object-type-delimeter rule does nothing, apparently because the
ObjectType{CallProperty,Indexer,Property}nodes no longer contain trailing semicolons/commas, but their parentObjectTypeAnnotationnodes do.I could not find a changelog or git commit entry in any of the associated projects for where/why this was changed...
I tried to keep compatibility with both cases, because it's not clear what version this project is targeting. However, I don't know of a good way to test the new behavior given the version of babel-eslint now locked in devDependencies.