fix(valid-types): regression with object field checking; fixes #1068

gajus · May 9, 2023 · 28fa65d · 28fa65d
1 parent 0e0e288
commit 28fa65d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/rules/validTypes.js b/src/rules/validTypes.js
@@ -164,8 +164,8 @@ export default iterateJsdoc(({
 
           if (
             (typ === 'JsdocTypeObjectField' || typ === 'JsdocTypeKeyValue') &&
-            node.right.type === 'JsdocTypeNullable' &&
-            node.right.meta.position === 'suffix'
+            node.right?.type === 'JsdocTypeNullable' &&
+            node.right?.meta?.position === 'suffix'
           ) {
             report(`Syntax error in type: ${node.right.type}`, null, tag);
           }

diff --git a/test/rules/assertions/validTypes.js b/test/rules/assertions/validTypes.js
@@ -1783,5 +1783,12 @@ export default {
         },
       },
     },
+    {
+      code: `
+      /**
+       * @returns {Promise<{publicKey, privateKey}>} - The public and private key
+       */
+      `,
+    },
   ],
 };