fix(require-jsdoc): handle spread elements in typescript-eslint/par…

…ser; for #378
gajus · Jan 7, 2020 · 3e8ea59 · 3e8ea59
1 parent b1ce407
commit 3e8ea59
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -8171,6 +8171,14 @@ export default class Foo {
  // ....
 }
 // Options: [{"exemptEmptyFunctions":false,"require":{"ClassDeclaration":true}}]
+
+const a = {};
+const b = {
+  ...a
+};
+
+export default b;
+// Options: [{"contexts":["ObjectExpression"],"exemptEmptyFunctions":false,"publicOnly":true}]
 ````
 
 

diff --git a/src/exportParser.js b/src/exportParser.js
@@ -105,7 +105,13 @@ const getSymbol = function (node, globals, scope, opt) {
     const val = createNode();
     val.type = 'object';
     node.properties.forEach((prop) => {
-      if (prop.type === 'ExperimentalSpreadProperty') {
+      if ([
+        // @typescript-eslint/parser, espree, acorn, etc.
+        'SpreadElement',
+
+        // babel-eslint
+        'ExperimentalSpreadProperty',
+      ].includes(prop.type)) {
         return;
       }
       const propVal = getSymbol(prop.value, globals, scope, opts);

diff --git a/test/rules/assertions/requireJsdoc.js b/test/rules/assertions/requireJsdoc.js
@@ -2383,5 +2383,26 @@ export default {
       sourceType: 'module',
     },
   },
+  {
+    code: `
+    const a = {};
+    const b = {
+      ...a
+    };
+
+    export default b;
+    `,
+    options: [
+      {
+        contexts: ['ObjectExpression'],
+        exemptEmptyFunctions: false,
+        publicOnly: true,
+      },
+    ],
+    parser: require.resolve('@typescript-eslint/parser'),
+    parserOptions: {
+      sourceType: 'module',
+    },
+  },
   ],
 };