Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With TypeScript CTRL+S adds bad comments to a function inside a class. #369

Closed
TimMouskhelichvili opened this issue Aug 22, 2019 · 4 comments
Closed

With TypeScript CTRL+S adds bad comments to a function inside a class. #369

TimMouskhelichvili opened this issue Aug 22, 2019 · 4 comments
Labels
bug help wanted released

Comments

@TimMouskhelichvili
Copy link

Hey guys!

Inside a class and pressing CTRL+S will add to this code.

class Dog {
	eat() {
		
	}
}

A comment like that:

class Dog {
    eat/**
 *
 */
() {
		
    }
}

Expected result:

class Dog {
    /**
     * 
     */
    eat() {
		
    }
}

P.S. I am using TypeScript.

Thank you guys.
@TimMouskhelichvili
Copy link
Author

Hello, @golopot.

I hope you are doing well. Any updates on that issue? The issue still happens when autofix is on.

@golopot
Copy link
Collaborator

golopot commented Oct 23, 2019

Pull requests are welcomed.

@brettz9 brettz9 mentioned this issue Oct 29, 2019
Merged
@brettz9 brettz9 closed this as completed in c1b5b46 May 3, 2020
@gajus
Copy link
Owner

gajus commented May 3, 2020

🎉 This issue has been resolved in version 24.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 3, 2020
brettz9 added a commit to dstaley/eslint-plugin-jsdoc that referenced this issue May 3, 2020
@brettz9
Merge branch 'master' into ds/destructuring
b1551df 
* master:
  fix(require-jsdoc): placement of jsdoc block by fixer; fixes gajus#369, gajus#403, gajus#502, gajus#522
  chore(travis): check Node 14
@gajus
Copy link
Owner

gajus commented May 9, 2020

🎉 This issue has been resolved in version 25.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gajus @TimMouskhelichvili @golopot