-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive with no-multi-asterisks
#773
Comments
We can look to overcome this for cases where the asterisk count is even, e.g.,: 4 (extra asterisks) % 2 = 0. /**
* **bold**
*/ However, I'm not sure we want to get into the harder and more error prone area of trying to fix cases like this: /**
* Here's a list:
* * item 1
* * item 2
*/ I think in the latter cases, we should just recommend people use the equally valid Markdown operator |
Can we simply only count leading/ending asterisks without spaces? // OK
/**
* Here's a list:
* * item 1
* * item 2
* **BOLD**
*/
// FAIL
/**
** Here's a list:
** * item 1
** * item 2
** **BOLD**
*/ |
I will work on this issue. |
You are missing the case (one of my use) where you have a line not ending with the end of the bold block. For example:
|
Aren't they all fail? /**
** Here's a list:
** * item 1
** * item 2
** **Note:** Hello there.
*/ Actually out use case is about a file header like the following /*
* *** INTERNAL ONLY ***
* -------------------------------------------------------------------------
* Unauthorized copying of this file, via any medium is strictly prohibited.
* -------------------------------------------------------------------------
*
* @summary ...
*
* @license Proprietary
* @copyright Copyright (c) 2021 - All Rights Reserved.
* -------------------------------------------------------------------------
*/ The easiest way to fix it of cause is us changing the format, but it wasn't a problem and I don't see it should be a problem. |
🎉 This issue has been resolved in version 37.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Expected behavior
With the default rules (
no-multi-asterisks
enabled), the following JSDoc should pass the linting:The bold text in Markdown should stay.
Actual behavior
The plugin auto-fixes the JSDoc like the following:
ESLint Config
Just the defaults.
ESLint sample
Environment
eslint-plugin-jsdoc
version: 35.5.1The text was updated successfully, but these errors were encountered: