Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid-types rule complains about @requires #840

Closed
adp-psych opened this issue Feb 17, 2022 · 2 comments
Closed

valid-types rule complains about @requires #840

adp-psych opened this issue Feb 17, 2022 · 2 comments

Comments

@adp-psych
Copy link

I have this at the top of a file:

/**
 * @file The scenarios of the experiment.
 *
 * @module module:scenarios/scenarios
 * @requires scenarios/effects
 * @author Anthony Di Pietro <anthony.dipietro@research.uwa.edu.au>
 * @copyright © 2020, 2021 Anthony Di Pietro
 * @license AGPL-3.0-or-later
 */

When I run ESLint, I get the following warning:

/home/user/.projects/psychology-phd/experiments/3/src/scenarios/scenarios.js
  22:0  warning  Syntax error in namepath: scenarios/effects  jsdoc/valid-types

I don’t understand why I’m getting this warning, and I wonder whether it might be spurious.

What should I do about this?

@brettz9 brettz9 added the bug label Feb 17, 2022
brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this issue Feb 17, 2022
brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this issue Feb 17, 2022
@gajus
Copy link
Owner

gajus commented Feb 17, 2022

🎉 This issue has been resolved in version 37.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Feb 17, 2022
@brettz9
Copy link
Collaborator

brettz9 commented Feb 17, 2022

Thanks for the report. In cases where module: was omitted, we had not been supplying our types parser with a copy that did have the module: path (so it could confirm the path was valid). Now fixed.

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this issue Feb 18, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | devDependencies | patch | [`37.9.1` -> `37.9.2`](https://renovatebot.com/diffs/npm/eslint-plugin-jsdoc/37.9.1/37.9.2) |

---

### Release Notes

<details>
<summary>gajus/eslint-plugin-jsdoc</summary>

### [`v37.9.2`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v37.9.2)

[Compare Source](gajus/eslint-plugin-jsdoc@v37.9.1...v37.9.2)

##### Bug Fixes

-   **`valid-types`:** ensure `requires` checking works without `module:`; fixes [#&#8203;840](gajus/eslint-plugin-jsdoc#840) ([0cfdfd7](gajus/eslint-plugin-jsdoc@0cfdfd7))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1177
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants