-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property context isn't working #841
Comments
Please provide the requested information. You have not provided any code that you expect to trigger. |
Closing until providing the required information. |
Sorry, I'm working with ts and wrote:
I expected foo to trigger, but I don't get anything linted. |
🎉 This issue has been resolved in version 37.9.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | devDependencies | patch | [`37.9.2` -> `37.9.4`](https://renovatebot.com/diffs/npm/eslint-plugin-jsdoc/37.9.2/37.9.4) | --- ### Release Notes <details> <summary>gajus/eslint-plugin-jsdoc</summary> ### [`v37.9.4`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v37.9.4) [Compare Source](gajus/eslint-plugin-jsdoc@v37.9.3...v37.9.4) ##### Bug Fixes - **`require-jsdoc`:** avoid class jsdoc blocks suppressing errors for `PropertyDefinition`; fixes [#​841](gajus/eslint-plugin-jsdoc#841) ([ef68427](gajus/eslint-plugin-jsdoc@ef68427)) ### [`v37.9.3`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v37.9.3) [Compare Source](gajus/eslint-plugin-jsdoc@v37.9.2...v37.9.3) ##### Bug Fixes - **`no-restricted-syntax`, `no-missing-syntax`:** update jsdoccomment to avoid breaking on bad types (at least until jsdoc-type-pratt-parser may support all expected); fixes [#​842](gajus/eslint-plugin-jsdoc#842) ([06c3163](gajus/eslint-plugin-jsdoc@06c3163)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1180 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sorry to bother you again. But the changes unfortunately have no effect on the behavior. I have applied the configuration of your changes:
And my code remains the same:
I expect the foo to be linted because no comment is provided. What is my error? Do you have any idea why it still doesn't work? In related issues, the ECMAScript version was often mentioned, I use es2015. Can this be related to that? With kind regards |
I have reconfirmed that your exact example is indeed now reporting an error as expected. If you are linting within an IDE, have you restarted the IDE? Some IDEs require this for the updates to take effect. If you are still seeing an issue despite running Re: the ES version, as long as you are using the TypeScript parser (which you need for your code), you shouldn't be getting any complaints, at least from ESLint, related to your choice of |
You might also try removing your |
Thank you for your quick responses. Sponsor you now, really top. I have deleted and reinstalled the Thank you!! |
Appreciate the sponsorship, thank you. But so you know, I can't guarantee I can always be super responsive, though I do hope to be for issues that are simple enough to resolve.
Hmm. Other nx users reporting a similar problem on #786 though not really sure that would be related. Are you able to report an issue to them or find a support chat or StackOverflow question about it? |
Do you have complex eslintrc settings where one config could be overriding another? |
I want to lint uncommented properties. For this, I use the
require-jsdoc
rule.In the context of the rule I use the given text
Property
which is in the documentation of the rule in the context section. But he doesn't lint my uncommented properties.Thank you for this nice project.
My configuration:
The text was updated successfully, but these errors were encountered: