check-types: Distinguish .<> from <>; support []; check/fix nested array/object types
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
parent-types
branch
2 times, most recently
from
cba9b01
to
5998592
Compare
|
Not sure if semantic release can handle multiple angular-type statements in a single commit... I didn't see docs about this... |
…instead to now support `SomeType<>` feat: pseudo-type `[]` to catch parent array types of form `string[]`, `number[]`, etc. feat: support `.<>` as separate type fix: ensure working with nested type arrays/objects fix: ensure fixer preserves angle-bracket-dot or square bracket notation for arrays/objects chore: Update husky, semantic-release devDeps; add `typescript` devDep for `type-fest` peer dep. (used indirectly by husky and semantic-release) Breaking change through `jsdoctypeparser` update.
gajus
approved these changes
Jun 11, 2019
It will just use whichever has the greatest power. In this case, the BREAKING CHANGE will just force a new major version (if I understand the question correctly). |
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: change
<>to no longer apply toSomeType.<>but instead to now supportSomeType<>feat: pseudo-type
[]to catch parent array types of formstring[],number[], etc.feat: support
.<>as separate typefix: ensure working with nested type arrays/objects
fix: ensure fixer preserves angle-bracket-dot or square bracket notation for arrays/objects
chore: Update husky, semantic-release devDeps; add
typescriptdevDep fortype-festpeer dep. (used indirectly by husky and semantic-release)Breaking change through
jsdoctypeparserupdate.Also includes a minor adjustment to
no-undefined-typesto be able to recognize types suffixed with the pseudo-types (e.g.,<>).This is currently being blocked by jsdoctypeparser/jsdoctypeparser#60 but once that may be merged and released, this PR should only need to target the new version as its dependency. (And tests failing here should be due to this need.)Now incorporated