Allow match-description to apply to descriptions of arbitrary tags
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
match-description-tags-expand
branch
3 times, most recently
from
6985244
to
d78cda5
Compare
…/`return` to avoid skipping matching of an initial "name" and space
brettz9
force-pushed
the
match-description-tags-expand
branch
from
d78cda5
to
2e14e34
Compare
golopot
approved these changes
Jul 8, 2019
|
🎉 This PR is included in version 14.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(
match-description): allow arbitrary tags; also fixesreturns/returnto avoid skipping matching of an initial "name" and spaceThe one disadvantage here is that because
tagsis an option instead of a setting, adding arbitrary tags doesn't make them automatically available tocheck-tag-namesas well.Also helps users work around lack of #233 support.