Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require-description-complete-sentence: limit checking by default to likely tags and new option array #338

Merged

Conversation

brettz9
Copy link
Collaborator

@brettz9 brettz9 commented Jul 14, 2019

feat(require-description-complete-sentence): limit checking to certain default tags likely to have descriptions or by tags array for additional choices; fixes #337

Tags that are checked for description by default are: 'param', 'arg', 'argument', 'property', 'prop', 'returns', 'return', 'summary', 'file', 'fileoverview', 'overview', 'classdesc', 'todo', 'deprecated', 'throws', 'exception', 'yields', 'yield'. Note that see and copyright are not included by default because of potentially allowing a non-description or potential sensitivity, respectively.

…n default tags likely to have descriptions or by `tags` array for additional choices; fixes gajus#337

Tags that are checked for description by default are: 'param', 'arg', 'argument', 'property', 'prop', 'returns', 'return', 'summary', 'file', 'fileoverview', 'overview', 'classdesc', 'todo', 'deprecated', 'throws', 'exception', 'yields', 'yield'. Note that `see` and `copyright` are not included by default because of potentially allowing a non-description or potential sensitivity, respectively.
@golopot golopot merged commit 0eb7a0c into gajus:master Jul 14, 2019
@gajus
Copy link
Owner

gajus commented Jul 14, 2019

🎉 This PR is included in version 15.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

require-description-complete-sentence false positives
3 participants