Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fixer for no-types #349

Closed
wants to merge 1 commit into from
Closed

feat: add fixer for no-types #349

wants to merge 1 commit into from

Conversation

yeonjuan
Copy link
Contributor

Add fixer for no-types(#336) : remove types

@brettz9
Copy link
Collaborator

brettz9 commented Jul 20, 2019

With comment-parser now including a stringify method, we should be able to make for a cleaner and less error prone fixing process by modifying jsdoc.tags and stringifying the result rather than attempting to parse and replace with strings and regular expressions. The latest in master (from commit 0503b4a ) adds a new method utils.reportJSDoc which can be used to report with a fixer that stringifies jsdocNode.

It would be great if you could rebase on master and see about reimplementing with that approach.

If there are any limitations in the comment-parser stringify or or in our API, let us know, so we can try to meet the need.

@yeonjuan yeonjuan closed this Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants