require-returns: check for Promise executor
#683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
changed the title
require-returns: check for executorrequire-returns: check for Promise executor
This was referenced Jan 29, 2021
Closed
… resolves with undefined, avoid need to document unless `forceReturnsWithAsync` is set; fixes gajus#550
… README (e.g., if just for coverage)
Also ignores coverage-focused test for README
brettz9
force-pushed
the
executor-resolves
branch
from
2cb5895
to
9da51d5
Compare
|
🎉 This PR is included in version 31.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(
require-returns): if function returns a Promise whose executor resolves with undefined, avoid need to document unlessforceReturnsWithAsyncis set; fixes #550Note that if this is merged, #682 will need to add mention that our
resolvedetection is not fully complete either, since there are more edge cases where this PR does not check. But I expect it is a good beginning.