-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Npmjs #64
Merged
Merged
Npmjs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anchors exist for any non-prefixing environments
Pull Request Test Coverage Report for Build 271
💛 - Coveralls |
Pull Request Test Coverage Report for Build 268
💛 - Coveralls |
Added a test and linted so now passing. |
@gajus : You able to do a review? |
@gajus : Any idea about an ETA on when you might be able to take a look at this? I expect I might need this beyond just |
🎉 This PR is included in version 3.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this now prefixes relative URL links, the second commit in this PR also adds its own "user-content-" anchors. While this is not strictly necessarily for GitHub or npmjs.com, it might be safer to ensure that the targeted anchors continue to exist for any environments which do not add the "user-content-" prefix. Let me know if you'd like me to remove this latter commit.
Fixes #63