Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npmjs #64

Merged
merged 5 commits into from
Mar 1, 2022
Merged

Npmjs #64

merged 5 commits into from
Mar 1, 2022

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Jan 4, 2022

  • fix: prefix relative URLs with "user-content-" for npmjs compatibility

As this now prefixes relative URL links, the second commit in this PR also adds its own "user-content-" anchors. While this is not strictly necessarily for GitHub or npmjs.com, it might be safer to ensure that the targeted anchors continue to exist for any environments which do not add the "user-content-" prefix. Let me know if you'd like me to remove this latter commit.

Fixes #63

@coveralls
Copy link

coveralls commented Jan 4, 2022

Pull Request Test Coverage Report for Build 271

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 89.381%

Totals Coverage Status
Change from base Build 266: 0.08%
Covered Lines: 395
Relevant Lines: 429

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 268

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.204%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/gitdown.js 5 6 83.33%
Totals Coverage Status
Change from base Build 266: -0.1%
Covered Lines: 394
Relevant Lines: 429

💛 - Coveralls

@brettz9
Copy link
Contributor Author

brettz9 commented Jan 4, 2022

Added a test and linted so now passing.

@brettz9
Copy link
Contributor Author

brettz9 commented Jan 21, 2022

@gajus : You able to do a review?

@brettz9
Copy link
Contributor Author

brettz9 commented Feb 6, 2022

@gajus : Any idea about an ETA on when you might be able to take a look at this? I expect I might need this beyond just eslint-plugin-jsdoc...

@gajus gajus merged commit 548d82f into gajus:master Mar 1, 2022
@gajus
Copy link
Owner

gajus commented Mar 1, 2022

🎉 This PR is included in version 3.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Mar 1, 2022
@brettz9 brettz9 deleted the npmjs branch January 1, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for links on npm
3 participants