feat: remove .<field> accessor

gajus · Nov 11, 2021 · 251e383 · 251e383
1 parent 6b5e77d
commit 251e383
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/src/grammar.ne b/src/grammar.ne
@@ -94,7 +94,7 @@ side ->
   | query {% d => ({field: '<implicit>', ...d[0]}) %}
 
 field ->
-    [._a-zA-Z$] [a-zA-Z\d_$.]:* {% d => d[0] + d[1].join('') %}
+    [_a-zA-Z$] [a-zA-Z\d_$.]:* {% d => d[0] + d[1].join('') %}
   | sqstring {% id %}
   | dqstring {% id %}
 

diff --git a/src/grammar.ts b/src/grammar.ts
@@ -227,7 +227,7 @@ const grammar: Grammar = {
     {"name": "side", "symbols": ["query"], "postprocess": d => ({field: '<implicit>', ...d[0]})},
     {"name": "field$ebnf$1", "symbols": []},
     {"name": "field$ebnf$1", "symbols": ["field$ebnf$1", /[a-zA-Z\d_$.]/], "postprocess": (d) => d[0].concat([d[1]])},
-    {"name": "field", "symbols": [/[._a-zA-Z$]/, "field$ebnf$1"], "postprocess": d => d[0] + d[1].join('')},
+    {"name": "field", "symbols": [/[_a-zA-Z$]/, "field$ebnf$1"], "postprocess": d => d[0] + d[1].join('')},
     {"name": "field", "symbols": ["sqstring"], "postprocess": id},
     {"name": "field", "symbols": ["dqstring"], "postprocess": id},
     {"name": "query", "symbols": ["relational_operator", "_", "decimal"], "postprocess": d => ({quoted: false, query: d[2], relationalOperator: d[0][0]})},

diff --git a/test/liqe/filter.ts b/test/liqe/filter.ts
@@ -114,9 +114,11 @@ test('"member"', testQuery, ['robert']);
 test('tags:"member"', testQuery, ['robert']);
 
 test('"London"', testQuery, ['mike']);
+test('city:"London"', testQuery, []);
 test('location.city:"London"', testQuery, ['mike']);
 
 test('membership:null', testQuery, ['noah']);
+test('attributes.member:null', testQuery, ['noah']);
 
 test('subscribed:true', testQuery, ['noah']);
 

diff --git a/test/liqe/parse.ts b/test/liqe/parse.ts
@@ -96,14 +96,6 @@ test('foo:bar', testQuery, {
   query: 'bar',
 });
 
-test('.foo:bar', testQuery, {
-  field: '.foo',
-  fieldPath: [
-    'foo',
-  ],
-  query: 'bar',
-});
-
 test('foo:   bar', testQuery, {
   field: 'foo',
   query: 'bar',