TypeScript: drop babel #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests defined for the types in https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/slonik/slonik-tests.ts Exports some new methods to make them pass. Some modifications made for breaking changes that weren't ported over there. Uses expect-type for testing
|
This is great |
mmkal
added a commit
to mmkal/slonik
that referenced
this pull request
Oct 21, 2020
* Type tests from definitely tests This adds tests defined for the types in https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/slonik/slonik-tests.ts Exports some new methods to make them pass. Some modifications made for breaking changes that weren't ported over there. Uses expect-type for testing * token types * Use generics for some internal types * Make createSqlTag generic * Switch from babel to typescript for building
|
🎉 This PR is included in version 22.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #209
Part of #195
This removes 10 (!) babel-related dev dependencies, and switches over build and test commands to use typescript only.
Some type changes were needed because
inline-loops.macrohas pretty loose types, and was letting us get away with more hand-waving thanArray.prototype.mapdoes.This loses the benefit of automatically naming anonymous functions (e.g. default exports), so in a follow-up PR I'm planning on switching to named exports. Lastly, I'll audit unnecessary comment directives.
nycworked fine for me locally withts-node, but let's see if coveralls is still able to pick up the report.