Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Object.values and String.prototype.trimEnd instead of lodash functions #127

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Use Object.values and String.prototype.trimEnd instead of lodash functions #127

merged 2 commits into from
Nov 19, 2020

Conversation

realityking
Copy link
Contributor

Some straightforward replacements that are possible thanks to Node.js 10

@realityking realityking mentioned this pull request Nov 19, 2020
Closed
@coveralls
Copy link

coveralls commented Nov 19, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 217

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.948%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/createStream.js 1 3 33.33%
Totals Coverage Status
Change from base Build 215: 0.0%
Covered Lines: 172
Relevant Lines: 236
💛 - Coveralls

@gajus gajus merged commit 9109426 into gajus:master Nov 19, 2020
@realityking realityking deleted the lodash-replacements branch November 19, 2020 21:19
@gajus
Copy link
Owner

gajus commented Nov 19, 2020

🎉 This PR is included in version 6.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@realityking @coveralls @gajus