Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ship flow files #142

Closed
wants to merge 1 commit into from
Closed

Conversation

realityking
Copy link
Contributor

Looking a bit more at the structure of the npm package and where its size comes from (see #137), the flow files stood out.

There are currently no flow types and Flow does not interpret JSDoc comments. This reduces the size of the dist folder by ~60%.

There are currently no flow types and Flow does not interpret JSDoc comments. This reduces the size of the dist folder by ~60%.
@coveralls
Copy link

coveralls commented Apr 7, 2021

Pull Request Test Coverage Report for Build 252

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.948%

Totals Coverage Status
Change from base Build 250: 0.0%
Covered Lines: 172
Relevant Lines: 236

💛 - Coveralls

@realityking
Copy link
Contributor Author

Made redundant by #147

@realityking realityking deleted the no-flow branch April 19, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants