Migrate to TypeScript #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 279
馃挍 - Coveralls |
Pull Request Test Coverage Report for Build 266
馃挍 - Coveralls |
gajus
reviewed
Apr 15, 2021
nam-hle
commented
Apr 18, 2021
|
|
||
| const config = makeConfig(rows, userConfig); | ||
|
|
||
| rows = truncateTableData(rows, config); |
There was a problem hiding this comment.
The old version is:
rows = truncateTableData(data, config);But I think it is a suitable modification :)
nam-hle
commented
Apr 18, 2021
Comment on lines
+27
to
+41
| const openRed = '\u001b[31m'; | ||
| const closeRed = '\u001b[39m'; | ||
| describe('subject is lesser than the chunk size', () => { | ||
| it.skip('returns subject in a single chunk', () => { | ||
| expect(wrapString(chalk.red('aaa'), 3)).to.deep.equal([ | ||
| '\u001B[31m\u001B[31m\u001B[31m\u001B[31m\u001B[31maaa\u001B[39m', | ||
| it('returns subject in a single chunk', () => { | ||
| expect(wrapString(`${openRed}aa${closeRed}`, 3)).to.deep.equal([ | ||
| `${openRed}aa${closeRed}`, | ||
| ]); | ||
| }); | ||
| }); | ||
| describe('subject is larger than the chunk size', () => { | ||
| it.skip('returns subject sliced into multiple chunks', () => { | ||
| expect(wrapString(chalk.red('aaabbbc'), 3)).to.deep.equal([ | ||
| '\u001B[31m\u001B[31m\u001B[31m\u001B[31m\u001B[31maaa\u001B[39m', | ||
| '\u001B[31m\u001B[31m\u001B[31m\u001B[31m\u001B[31mbbb\u001B[39m', | ||
| '\u001B[31m\u001B[31m\u001B[31m\u001B[31m\u001B[31mc\u001B[39m', | ||
| it('returns subject sliced into multiple chunks', () => { | ||
| expect(wrapString(`${openRed}aaabbbc${closeRed}`, 3)).to.deep.equal([ | ||
| `${openRed}aaa${closeRed}`, | ||
| `${openRed}bbb${closeRed}`, | ||
| `${openRed}c${closeRed}`, |
There was a problem hiding this comment.
This is a workaround for the unexpected behaviors of chalk while testing.
|
馃コ |
|
馃帀 This PR is included in version 6.3.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
|
Awesome 馃ぉ |
This was referenced Apr 19, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for migrating the package to TypeScript (#146) with major changes (but should not contain breaking changes 馃檹):
Additionally, the schema definitions could generate from type definitions with third-party libraries like ts-json-schema-generator. By doing that, we can safely remove most of the checking code lines and maybe primitive type checking package like is-boolean, is-number,... But of course, we should do it later :D