return instead of ignore error (#1287)

* return error instead of swallow error * changelog Co-authored-by: Bryan Stitt <bryan@satoshiandkin.com>
gakonst · May 23, 2022 · 9ed9395 · 9ed9395
1 parent fe4de84
commit 9ed9395
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -67,6 +67,7 @@
 - Add `TransactionReceipt::to` and `TransactionReceipt::from`
   [#1184](https://github.com/gakonst/ethers-rs/pull/1184)
 - Add `From<H160>` and From<Vec<H160>> traits to `ValueOrArray<H160>` [#1199](https://github.com/gakonst/ethers-rs/pull/1200)
+- Fix handling of Websocket connection errors [#1287](https://github.com/gakonst/ethers-rs/pull/1287)
 
 ## ethers-contract-abigen
 

diff --git a/ethers-providers/src/transports/ws.rs b/ethers-providers/src/transports/ws.rs
@@ -401,8 +401,9 @@ where
             // Handle ws messages
             resp = self.ws.next() => match resp {
                 Some(Ok(resp)) => self.handle(resp).await?,
-                // TODO: Log the error?
-                Some(Err(_)) => {},
+                Some(Err(_)) => {
+                    return Err(ClientError::UnexpectedClose);
+                }
                 None => {
                     return Err(ClientError::UnexpectedClose);
                 },