Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples running forever #1036

Closed
gakonst opened this issue Mar 15, 2022 · 1 comment · Fixed by #1040
Closed

examples running forever #1036

gakonst opened this issue Mar 15, 2022 · 1 comment · Fixed by #1040
Labels
bug Something isn't working

Comments

@gakonst
Copy link
Owner

gakonst commented Mar 15, 2022

For some reason, Examples keep running without ending. here's an example workflow https://github.com/gakonst/ethers-rs/runs/5553524129?check_suite_focus=true. this is not reproduced locally. the command is basically "run all bins under the examples/ dir" https://github.com/gakonst/ethers-rs/blob/master/scripts/examples.sh. https://github.com/gakonst/ethers-rs/blob/master/.github/workflows/ci.yml#L178
@gakonst gakonst added the bug Something isn't working label Mar 15, 2022
@mattsse mattsse mentioned this issue Mar 16, 2022
Merged
3 tasks
@gakonst gakonst reopened this Mar 17, 2022
gakonst added a commit that referenced this issue Mar 17, 2022
@gakonst
ci: temporarily disable examples
2933bb2 
ref: #1036
@mattsse
Copy link
Collaborator

mattsse commented Apr 4, 2022

vote close

@gakonst gakonst closed this as completed Apr 4, 2022
jsLover1117 added a commit to jsLover1117/ethers-rs that referenced this issue Jul 17, 2022
@jsLover1117
ci: temporarily disable examples
98e5bde 
ref: gakonst/ethers-rs#1036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(examples): adjust breaking changes and detect failures in ci mattsse/ethers-rs
2 participants
@gakonst @mattsse