Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authorization for http and websocket #829

Merged
merged 10 commits into from Jan 27, 2022
Merged

Add authorization for http and websocket #829

merged 10 commits into from Jan 27, 2022

Conversation

th4s
Copy link
Contributor

@th4s th4s commented Jan 25, 2022

Summary

This pull request adds basic and bearer authentication for http and non-wasm websockets transport.

Motivation

Some people operate their node behind a reverse-proxy which uses some form of authentication. This pull request makes it possible to use ethers-rs in this case.

Solution

The solution is to inject auth headers into http requests and the websocket handshake request.

PR Checklist

  • Added Tests (Is that necessary in this, case? If yes, how would you do that?
  • Added Documentation
  • Updated the changelog

mattsse
mattsse requested changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this,
some suggestions and few nits

ethers-providers/src/transports/http.rs Outdated Show resolved Hide resolved
ethers-providers/src/transports/http.rs Outdated Show resolved Hide resolved
ethers-providers/src/transports/ws.rs Show resolved Hide resolved
ethers-providers/src/transports/ws.rs Outdated Show resolved Hide resolved
ethers-providers/src/transports/ws.rs Outdated Show resolved Hide resolved
ethers-providers/src/transports/common.rs Outdated Show resolved Hide resolved
mattsse
mattsse requested changes Jan 26, 2022
View reviewed changes
ethers-providers/src/transports/common.rs Outdated Show resolved Hide resolved
ethers-providers/src/transports/common.rs Outdated Show resolved Hide resolved
@th4s
Copy link
Contributor Author

th4s commented Jan 26, 2022

Thanks for your feedback!

mattsse
mattsse approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nit but lgtm!

@th4s
Copy link
Contributor Author

th4s commented Jan 26, 2022

Thanks a lot!

gakonst
gakonst approved these changes Jan 27, 2022
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@gakonst gakonst merged commit a97526d into gakonst:master Jan 27, 2022
@mattsse mattsse mentioned this pull request Jan 27, 2022
Merged
@ZePedroResende ZePedroResende mentioned this pull request Jun 9, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@th4s @gakonst @mattsse