feat(solc): use relative paths and --base-path option #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mattsse
added a commit
to mattsse/ethers-rs
that referenced
this pull request
May 28, 2022
* feat(solc): use relative paths and --base-path option * chore: update CHANGELOG * strip lib paths
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1315
working with paths is hard.
Ideally, we want to work with absolute paths because we resolve them in the Graph anyway and
Project::rootis not guaranteed to be cwd.however, absolute/relative paths result in different solc metadata, so when invoking solc, we want to be consistent, or rather OS and local disk independent.
with 0.6.9, solc supports a
--base-pathoption so we use that instead and also set the cwd of the solc process toProject::root.This also introduces the
CompilerInput::with_base_pathfunction that will stripProject::rootfrom:Solution
PR Checklist