feat(solc): emit additional raw metadata field #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The --all-features tests seem to be hanging for some reason.. Is the unit test failure a flake? |
forgot that solc emits empty string for metadata regardless... improved the json_opt deserialization |
mattsse
force-pushed
the
matt/lossless-metadata
branch
from
a9209cc
to
3eb8a53
Compare
this is super annoying because for some reason there are no logs available for the job... perhaps this is due to some hanging request, but testing locally works... |
|
@gakonst after looking at jobs that timed out, it looks like https://github.com/gakonst/ethers-rs/runs/6801222172?check_suite_focus=true ignored it for now until I debugged this on anvil |
mattsse
force-pushed
the
matt/lossless-metadata
branch
from
db2160d
to
3eb8a53
Compare
gakonst
approved these changes
Jun 10, 2022
| @@ -66,8 +66,8 @@ pub mod json_string_opt { | |||
| if s.is_empty() { | |||
| return Ok(None) | |||
| } | |||
|
|
|||
| serde_json::from_str(&s).map_err(de::Error::custom).map(Some) | |||
| let value = serde_json::Value::String(s); | |||
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1325
Solution
add an additional
rawMetadata:Stringfield to artifact output which preserves solc's metadata stringPR Checklist