Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ethers-solc): configurable build-info output dir #1433

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 30, 2022

Motivation

I would like to be able to configure the output directory of the hh style bulidinfo files so that tooling that expects the build info files to be in a specific directory can just work.

Solution

Allows for the build info output directory to be configured. It should be backwards compatible by using the same directory that it currently uses by default. Will require a follow up PR in foundry to pass through the config value

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@tynes tynes force-pushed the feat/configurable-build-infos branch from 0b07f89 to 6c2ce8d Compare June 30, 2022 05:20
@tynes tynes force-pushed the feat/configurable-build-infos branch from 6c2ce8d to 1802efd Compare June 30, 2022 05:23
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

we can follow up with a corresponding config value in foundry.toml

the way that works is, the Config struct contains all settings variables:
https://github.com/foundry-rs/foundry/blob/master/config/src/lib.rs#L90-L108

which are picked up by foundry.toml, env, cli args ...

and are then used to create the ethers-solc::Project here

https://github.com/foundry-rs/foundry/blob/master/config/src/lib.rs#L528

@tynes
Copy link
Contributor Author

tynes commented Jun 30, 2022

this is great!

we can follow up with a corresponding config value in foundry.toml

the way that works is, the Config struct contains all settings variables: https://github.com/foundry-rs/foundry/blob/master/config/src/lib.rs#L90-L108

which are picked up by foundry.toml, env, cli args ...

and are then used to create the ethers-solc::Project here

https://github.com/foundry-rs/foundry/blob/master/config/src/lib.rs#L528

Thanks for the tips! Will open PRs in foundry and the hh plugin once this version of ethers is pulled into foundry

@gakonst gakonst merged commit 3bafe5b into gakonst:master Jun 30, 2022
@mattsse
Copy link
Collaborator

mattsse commented Jun 30, 2022

merged into foundry with foundry-rs/foundry#2168

@tynes tynes deleted the feat/configurable-build-infos branch July 3, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants