Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: debug_traceCall #1949

Merged
merged 3 commits into from
Dec 25, 2022
Merged

feat: debug_traceCall #1949

merged 3 commits into from
Dec 25, 2022

Conversation

Vid201
Copy link
Contributor

@Vid201 Vid201 commented Dec 18, 2022

Motivation

Minimal implementation of #1801 debug_traceCall.

Solution

Similar implementation to debug_traceTransaction.

stateoverrides and blockoverrides trace options were not implemented.

PR Checklist

  • Added Documentation
  • Updated the changelog

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
can do overrides in followup

examples/geth_trace_call.rs Outdated Show resolved Hide resolved
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geth's debug api has come a long way!

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geth's debug api has come a long way!

@gakonst
Copy link
Owner

gakonst commented Dec 22, 2022

Smol merge conflict lgtm otherwise

@Vid201 Vid201 requested a review from gakonst December 22, 2022 22:54
@gakonst gakonst merged commit b27c7b0 into gakonst:master Dec 25, 2022
@gakonst
Copy link
Owner

gakonst commented Dec 25, 2022

sick work mate, welcome :)

@Vid201 Vid201 deleted the feat/debug_traceCall branch January 19, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants