Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix tests and dev features #2293

Merged
merged 9 commits into from
Apr 13, 2023
Merged

test: fix tests and dev features #2293

merged 9 commits into from
Apr 13, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes marked this pull request as draft March 21, 2023 22:19
@DaniPopes
Copy link
Collaborator Author

waiting on CI

@DaniPopes DaniPopes marked this pull request as ready for review March 21, 2023 23:22
mattsse
mattsse reviewed Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the remaining warning is about future incompatibility which we can ignore,

perhaps we can allow this via cli arg?

@prestwich
Copy link
Collaborator

Is this work still current? needs rebase due to changes to eip712 and ci.yml in recent PRs.

@DaniPopes DaniPopes changed the title fix: test features test: fix tests and dev features Apr 10, 2023
@DaniPopes DaniPopes mentioned this pull request Apr 10, 2023
Merged
3 tasks
@gakonst gakonst merged commit 5c0de28 into gakonst:master Apr 13, 2023
11 of 15 checks passed
@DaniPopes DaniPopes deleted the fix/solc-features2 branch April 13, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DaniPopes @prestwich @gakonst @mattsse