chore: Add ZKSync into the Chain type #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested changes
Mar 26, 2023
ethers-core/src/types/chain.rs
Outdated
| @@ -140,6 +140,8 @@ pub enum Chain { | |||
| CantoTestnet = 740, | |||
|
|
|||
| Boba = 288, | |||
|
|
|||
| ZKSync = 324, | |||
There was a problem hiding this comment.
this needs to be renamed to lowercase for serde and strum, see the comments at the top of the file on how to do it
ethers-core/src/types/chain.rs
Outdated
| EmeraldTestnet | Boba => return None, | ||
| Morden | Ropsten | Rinkeby | Goerli | Kovan | XDai | Chiado | Sepolia | Moonbase | ||
| | MoonbeamDev | Optimism | OptimismGoerli | OptimismKovan | Poa | Sokol | Rsk | ||
| | EmeraldTestnet | Boba | ZKSync => return None, |
There was a problem hiding this comment.
please use the nightly toolchain to format your code
(cargo +nightly fmt)
There was a problem hiding this comment.
I've run cargo +nigtly fmt in the project
DaniPopes
reviewed
Mar 27, 2023
ethers-core/src/types/chain.rs
Outdated
| @@ -460,6 +463,10 @@ impl Chain { | |||
|
|
|||
| Boba => ("https://api.bobascan.com/api", "https://bobascan.com"), | |||
|
|
|||
| ZKSync => { | |||
There was a problem hiding this comment.
one last thing, this wasn't renamed (you can see the warnings by running cargo clippy -p ethers-core)
Suggested change
| ZKSync => { | |
| Zksync => { |
There was a problem hiding this comment.
resolved in another commit :D thx
|
2 requests:
|
gakonst
force-pushed
the
chore/zksync-chain
branch
from
4d2c769
to
bf7e4ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist