Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate feature declaration #2309

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

Missed due to build failing either way for the generic_array problem. Sorry about this

See: https://github.com/gakonst/ethers-rs/actions/runs/4546190395/jobs/8014511517

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes changed the title fix: docsrs cfg_attr fix: duplicate feature declaration Mar 29, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gakonst gakonst merged commit d140e72 into gakonst:master Apr 1, 2023
@DaniPopes DaniPopes deleted the fix/docsrs-build branch April 1, 2023 13:26
@DaniPopes DaniPopes mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants