fix: poll stream until pending #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
Apr 10, 2023
| }, | ||
| None => Poll::Ready(None), | ||
| let mut this = self.project(); | ||
| loop { |
There was a problem hiding this comment.
isn't this loop a no-op, as the return always ends it on the first loop?
There was a problem hiding this comment.
nvm i am misreading the code
There was a problem hiding this comment.
This continues the poll rx on Err(err) instead of returning Pending, and ensures that the underlying stream is completely drained or returns a valid element.
prestwich
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
streams only register the waker if they're pending
Returning "pending" when the underlying stream is still ready does not ensure that the rt will poll again.
Solution
PR Checklist