Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add from_x_or_hex to remaining genesis fields #2360

Merged
merged 5 commits into from
Apr 18, 2023
Merged

fix(core): add from_x_or_hex to remaining genesis fields #2360

merged 5 commits into from
Apr 18, 2023

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Apr 18, 2023 •
edited

Motivation

Some fields were missed for Genesis decimal string deserialization.

Solution

Followup to #2359, adding remaining deserializers to Genesis fields.

This changes usages of from_int_or_hex to deserialize_stringified_numeric, and removes the from_int_or_hex methods.

Modifies StringifiedNumeric to support arbitrary precision.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that the Uint types use decimal string if 0x is missing is a bot horrible

@gakonst gakonst merged commit 6ebb1b2 into gakonst:master Apr 18, 2023
12 of 15 checks passed
@gakonst gakonst mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rjected @mattsse @gakonst