feat: add geth debug_traceBlock methods #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsh98
commented
Apr 19, 2023
ethers-core/src/types/trace/geth.rs
Outdated
Comment on lines
90
to
118
|
|
||
| #[derive(Debug, PartialEq, Eq, Clone, Deserialize, Serialize)] | ||
| #[serde(untagged)] | ||
| pub enum GethTraceResult { | ||
| ResultKnown{result: GethTraceFrame}, | ||
| ResultUnknown{result: Value}, | ||
| DefaultKnown(GethTraceFrame), | ||
| DefaultUnknown(Value), | ||
| } | ||
|
|
||
| #[derive(Debug, PartialEq, Eq, Clone, Deserialize, Serialize)] | ||
| #[serde(from = "GethTraceResult")] | ||
| #[serde(untagged)] | ||
| pub enum GethTrace { | ||
| Known(GethTraceFrame), | ||
| Unknown(Value), | ||
| } | ||
|
|
||
| impl From<GethTraceResult> for GethTrace { | ||
| fn from(value: GethTraceResult) -> Self { | ||
| match value { | ||
| GethTraceResult::DefaultKnown(t) => GethTrace::Known(t), | ||
| GethTraceResult::DefaultUnknown(v) => GethTrace::Unknown(v), | ||
| GethTraceResult::ResultKnown{result} => GethTrace::Known(result), | ||
| GethTraceResult::ResultUnknown{result} => GethTrace::Unknown(result), | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This could probably be cleaned up. It was done to convert a batch of traces to a Vec<GethTrace> since debug_traceBlock wraps each trace in a "result" key.
Example raw response:
{
"jsonrpc": "2.0",
"id": 1,
"result": [
{
"result": {
"from": "0x1b7aa44088a0ea95bdc65fef6e5071e946bf7d8f",
"gas": "0x0",
"gasUsed": "0x5208",
"to": "0x7cb47db064be90f6ace1673ebfe5b3a102f369b8",
"input": "0x",
"value": "0xb1a2bc2ec50000",
"type": "CALL"
}
},
{
"result": {
"from": "0xe77e6c57b20b3de8c998b4552126feaeaf32b762",
"gas": "0x2ee0",
...
|
Thank you! Clippy, formatting, and tests have been fixed. Test was failing when calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support for more Geth
debugmethods.Solution
Adds
debug_traceBlockByNumberanddebug_traceBlockByHashRPC methods.PR Checklist